ui/views/controls/webview/webview.cc - Issue 1690543004: MacViews: Implement Full Keyboard Access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/webview/webview.cc

Issue 1690543004: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed review comments. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/webview/webview.cc

diff --git a/ui/views/controls/webview/webview.cc b/ui/views/controls/webview/webview.cc

index 44baa228dc32c69c48a85537ce4c832f9d49f37b..dd500cf66ec1fd84e99242ebbb5d1e599ca4d0e8 100644

--- a/ui/views/controls/webview/webview.cc

+++ b/ui/views/controls/webview/webview.cc

@@ -67,7 +67,8 @@ void WebView::SetWebContents(content::WebContents* replacement) {

observing_render_process_host_->AddObserver(this);

}

// web_contents() now returns |replacement| from here onwards.

- SetFocusable(!!web_contents());

+ SetFocusBehavior(web_contents() ? FocusBehavior::CONTROL

karandeepb 2016/03/17 07:24:47 I am not sure what's the correct value here - CONT

+ : FocusBehavior::NEVER);

if (wc_owner_.get() != replacement)

wc_owner_.reset();

if (embed_fullscreen_widget_mode_enabled_) {

« no previous file with comments | « ui/views/controls/tree/tree_view.cc ('k') | ui/views/focus/focus_manager.h » ('j') | no next file with comments »