MacViews: Implement Full Keyboard Access.

ui/views/controls/link.cc

Index: ui/views/controls/link.cc
diff --git a/ui/views/controls/link.cc b/ui/views/controls/link.cc
index adbe647aaf4d8262619a736437f27da376fd18f0..f5c2dc4ab6b48b3850a7f32333779bf7fc5475f8 100644
--- a/ui/views/controls/link.cc
+++ b/ui/views/controls/link.cc
@@ -159,10 +159,17 @@ void Link::SetFontList(const gfx::FontList& font_list) {
 
 void Link::SetText(const base::string16& text) {
   Label::SetText(text);
+
+#if !defined(OS_MACOSX)
   // Disable focusability for empty links.  Otherwise Label::GetInsets() will
   // give them an unconditional 1-px. inset on every side to allow for a focus
   // border, when in this case we probably wanted zero width.
   SetFocusable(!text.empty());
+#else
+  // On Mac, only allow links to have focus, when the accessibility mode is on.

[tapted, 2016/02/12 02:56:44]

this isn't what Chrome does in the content area -- links are focused when
eaccessibility mode is off, so I think the UI should be consistent with that (..
even if it's not what Safari does..)

[karandeepb, 2016/02/22 07:15:37]

As discussed, keeping the links not focusable by default on Mac.

+  SetFocusable(false);
+  SetAccessibilityFocusable(!text.empty());
+#endif
 }
 
 void Link::OnNativeThemeChanged(const ui::NativeTheme* theme) {
@@ -198,9 +205,14 @@ void Link::Init() {
 
   // Label::Init() calls SetText(), but if that's being called from Label(), our
   // SetText() override will not be reached (because the constructed class is
-  // only a Label at the moment, not yet a Link).  So so the set_focusable()
-  // call explicitly here.
+// only a Label at the moment, not yet a Link).  So explicitly set focusability
+// here.
+#if !defined(OS_MACOSX)
   SetFocusable(!text().empty());
+#else
+  SetFocusable(false);
+  SetAccessibilityFocusable(!text().empty());
+#endif
 }
 
 void Link::SetPressed(bool pressed) {