MacViews: Implement Full Keyboard Access.

ui/views/controls/link.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/link.h"
 
 #include "build/build_config.h"
 
 #include "base/logging.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 141 matching lines @@
   SchedulePaint();
 }
 
 void Link::SetFontList(const gfx::FontList& font_list) {
   Label::SetFontList(font_list);
   RecalculateFont();
 }
 
 void Link::SetText(const base::string16& text) {
   Label::SetText(text);
+
+#if !defined(OS_MACOSX)
   // Disable focusability for empty links.  Otherwise Label::GetInsets() will
   // give them an unconditional 1-px. inset on every side to allow for a focus
   // border, when in this case we probably wanted zero width.
   SetFocusable(!text.empty());
+#else
+  // On Mac, only allow links to have focus, when the accessibility mode is on.

[tapted, 2016/02/12 02:56:44]

this isn't what Chrome does in the content area -- links are focused when
eaccessibility mode is off, so I think the UI should be consistent with that (..
even if it's not what Safari does..)

[karandeepb, 2016/02/22 07:15:37]

As discussed, keeping the links not focusable by default on Mac.

+  SetFocusable(false);
+  SetAccessibilityFocusable(!text.empty());
+#endif
 }
 
 void Link::OnNativeThemeChanged(const ui::NativeTheme* theme) {
   Label::SetEnabledColor(GetEnabledColor());
   SetDisabledColor(
       theme->GetSystemColor(ui::NativeTheme::kColorId_LinkDisabled));
 }
 
 void Link::SetEnabledColor(SkColor color) {
   requested_enabled_color_set_ = true;
@@ skipping 15 matching lines @@
 }
 
 void Link::Init() {
   listener_ = NULL;
   pressed_ = false;
   underline_ = true;
   RecalculateFont();
 
   // Label::Init() calls SetText(), but if that's being called from Label(), our
   // SetText() override will not be reached (because the constructed class is
-  // only a Label at the moment, not yet a Link).  So so the set_focusable()
-  // call explicitly here.
+// only a Label at the moment, not yet a Link).  So explicitly set focusability
+// here.
+#if !defined(OS_MACOSX)
   SetFocusable(!text().empty());
+#else
+  SetFocusable(false);
+  SetAccessibilityFocusable(!text().empty());
+#endif
 }
 
 void Link::SetPressed(bool pressed) {
   if (pressed_ != pressed) {
     pressed_ = pressed;
     Label::SetEnabledColor(GetEnabledColor());
     RecalculateFont();
     SchedulePaint();
   }
 }
@@ skipping 19 matching lines @@
   }
 
   if (!requested_pressed_color_set_ && GetNativeTheme())
     return GetNativeTheme()->GetSystemColor(
         ui::NativeTheme::kColorId_LinkPressed);
 
   return requested_pressed_color_;
 }
 
 }  // namespace views