chrome/browser/ui/views/autofill/autofill_dialog_views.cc - Issue 1690543004: MacViews: Implement Full Keyboard Access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/autofill/autofill_dialog_views.cc

Issue 1690543004: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix FocusManagerTest.StoreFocusedView Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/autofill/autofill_dialog_views.cc

diff --git a/chrome/browser/ui/views/autofill/autofill_dialog_views.cc b/chrome/browser/ui/views/autofill/autofill_dialog_views.cc

index ddf5d9b9d57609d4977a1b22a9679bdc8d588112..94f2a520d6888244ba69e06ba3cc2b0e792e81f9 100644

--- a/chrome/browser/ui/views/autofill/autofill_dialog_views.cc

+++ b/chrome/browser/ui/views/autofill/autofill_dialog_views.cc

@@ -63,6 +63,7 @@

#include "ui/views/layout/grid_layout.h"

#include "ui/views/layout/layout_constants.h"

#include "ui/views/painter.h"

+#include "ui/views/style/platform_style.h"

#include "ui/views/view_targeter.h"

#include "ui/views/widget/widget.h"

#include "ui/views/window/dialog_client_view.h"

@@ -623,7 +624,7 @@ AutofillDialogViews::SuggestedButton::SuggestedButton(

-kFocusBorderWidth, -kFocusBorderWidth);

SetFocusPainter(

views::Painter::CreateDashedFocusPainterWithInsets(insets));

- SetFocusable(true);

+ views::PlatformStyle::SetControlStyleFocus(this);

}

AutofillDialogViews::SuggestedButton::~SuggestedButton() {}