chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc - Issue 1690543004: MacViews: Implement Full Keyboard Access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc

Issue 1690543004: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix FocusManagerTest.StoreFocusedView Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc

diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc

index 82964d9b6323162bbd957554149123a23a689a81..712eb6fa0b72443949adff87d379c3c659235e75 100644

--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc

+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc

@@ -29,6 +29,7 @@

#include "ui/views/layout/box_layout.h"

#include "ui/views/layout/grid_layout.h"

#include "ui/views/layout/layout_constants.h"

+#include "ui/views/style/platform_style.h"

#include "ui/views/view.h"

namespace {

@@ -62,7 +63,7 @@ class RevokeButton : public views::ImageButton, public views::ButtonListener {

// Make the button focusable & give it alt-text so permissions can be

// revoked using only the keyboard.

- SetFocusable(true);

+ views::PlatformStyle::SetControlStyleFocus(this);

SetTooltipText(l10n_util::GetStringFUTF16(

IDS_APPLICATION_INFO_REVOKE_PERMISSION_ALT_TEXT, permission_message));

}

« no previous file with comments | « no previous file | chrome/browser/ui/views/autofill/autofill_dialog_views.cc » ('j') | chrome/browser/ui/views/download/download_shelf_view.cc » ('J')