Add fine grained command line and service protocol control over timeline streams recording

Add fine grained command line and service protocol control over timeline streams recording

- Add --timeline-streams= flag which takes a comma separated list of streams to record.
- Send "availableStreams" and "recordedStreams" in the _getVMTimelineFlags RPC. Also include the type of recorder we are using.
- Enable setting of "recordedStreams" in the _setVMTimelineFlags RPC.

R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/cda760915c68f7634234127e558100933fac0e49

[Cutch, 2016-02-12 17:46:37]

Description was changed from

==========
Add command line and service protocol control over timeline streams

BUG=
==========

to

==========
Add fine grained command line and service protocol control over timeline streams
recording

- Add --timeline-streams= flag which takes a comma separated list of streams to
record.
- Send "availableStreams" and "recordedStreams" in the _getVMTimelineFlags RPC.
Also include the type of recorder we are using.
- Enable setting of "recordedStreams" in the _setVMTimelineFlags RPC.
==========

[Cutch, 2016-02-12 17:46:37]

johnmccutchan@google.com changed reviewers:
+ zra@google.com

[zra, 2016-02-12 18:57:56]

https://codereview.chromium.org/1690333002/diff/1/runtime/observatory/tests/s...
File runtime/observatory/tests/service/vm_timeline_flags_test.dart (right):

https://codereview.chromium.org/1690333002/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/vm_timeline_flags_test.dart:1: // Copyright
(c) 2015, the Dart project authors.  Please see the AUTHORS file
2016

https://codereview.chromium.org/1690333002/diff/1/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/1690333002/diff/1/runtime/vm/service.cc#newco...
runtime/vm/service.cc:2873: new EnumListParameter("recordedStreams",
Where is this deleted?

https://codereview.chromium.org/1690333002/diff/1/runtime/vm/service.cc#newco...
runtime/vm/service.cc:2879: recorded_streams_param,
Does this rely on the order that globals are initialized in? Is that
well-defined?

https://codereview.chromium.org/1690333002/diff/1/runtime/vm/service.cc#newco...
runtime/vm/service.cc:2905:
Timeline::SetStreamAPIEnabled(HasStream(recorded_streams, "API"));
Is it possible to use ISOLATE_TIMELINE_STREAM_LIST here?

https://codereview.chromium.org/1690333002/diff/1/runtime/vm/timeline.cc
File runtime/vm/timeline.cc (right):

https://codereview.chromium.org/1690333002/diff/1/runtime/vm/timeline.cc#newc...
runtime/vm/timeline.cc:96: OS::Print("%s\n", s);
Leftover debug print?

https://codereview.chromium.org/1690333002/diff/1/runtime/vm/timeline.cc#newc...
runtime/vm/timeline.cc:154:
FreeEnabledByDefaultTimelineStreams(enabled_streams);
Will this ever be different? Why not cache it somewhere for SetupIsolateStreams
to use, and then free it in Timeline::Shutdown()? It'll be read-only after
initialization, it looks like.

https://codereview.chromium.org/1690333002/diff/1/runtime/vm/timeline.cc#newc...
runtime/vm/timeline.cc:183: 
Missing newline

https://codereview.chromium.org/1690333002/diff/1/runtime/vm/timeline.cc#newc...
runtime/vm/timeline.cc:262: 
Missing newline

[Cutch, 2016-02-12 20:13:57]

https://codereview.chromium.org/1690333002/diff/1/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/1690333002/diff/1/runtime/vm/service.cc#newco...
runtime/vm/service.cc:2873: new EnumListParameter("recordedStreams",
On 2016/02/12 18:57:56, zra wrote:
> Where is this deleted?

It's not and none of our parameter lists are.

https://codereview.chromium.org/1690333002/diff/1/runtime/vm/service.cc#newco...
runtime/vm/service.cc:2879: recorded_streams_param,
On 2016/02/12 18:57:56, zra wrote:
> Does this rely on the order that globals are initialized in? Is that
> well-defined?

Fixed here and elsewhere.

https://codereview.chromium.org/1690333002/diff/1/runtime/vm/service.cc#newco...
runtime/vm/service.cc:2905:
Timeline::SetStreamAPIEnabled(HasStream(recorded_streams, "API"));
On 2016/02/12 18:57:56, zra wrote:
> Is it possible to use ISOLATE_TIMELINE_STREAM_LIST here?

Done.

https://codereview.chromium.org/1690333002/diff/1/runtime/vm/timeline.cc
File runtime/vm/timeline.cc (right):

https://codereview.chromium.org/1690333002/diff/1/runtime/vm/timeline.cc#newc...
runtime/vm/timeline.cc:96: OS::Print("%s\n", s);
On 2016/02/12 18:57:56, zra wrote:
> Leftover debug print?

Done.

https://codereview.chromium.org/1690333002/diff/1/runtime/vm/timeline.cc#newc...
runtime/vm/timeline.cc:154:
FreeEnabledByDefaultTimelineStreams(enabled_streams);
On 2016/02/12 18:57:56, zra wrote:
> Will this ever be different? Why not cache it somewhere for
SetupIsolateStreams
> to use, and then free it in Timeline::Shutdown()? It'll be read-only after
> initialization, it looks like.

Done.

https://codereview.chromium.org/1690333002/diff/1/runtime/vm/timeline.cc#newc...
runtime/vm/timeline.cc:183: 
On 2016/02/12 18:57:56, zra wrote:
> Missing newline

Done.

https://codereview.chromium.org/1690333002/diff/1/runtime/vm/timeline.cc#newc...
runtime/vm/timeline.cc:262: 
On 2016/02/12 18:57:56, zra wrote:
> Missing newline

Done.

[zra, 2016-02-12 20:23:55]

lgtm with TODO

https://codereview.chromium.org/1690333002/diff/1/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/1690333002/diff/1/runtime/vm/service.cc#newco...
runtime/vm/service.cc:2873: new EnumListParameter("recordedStreams",
On 2016/02/12 20:13:57, Cutch wrote:
> On 2016/02/12 18:57:56, zra wrote:
> > Where is this deleted?
> 
> It's not and none of our parameter lists are.

If there isn't one already, please file a bug to clean these up and add a TODO.

[Cutch, 2016-02-12 21:18:07]

On 2016/02/12 20:23:55, zra wrote:
> lgtm with TODO
> 
> https://codereview.chromium.org/1690333002/diff/1/runtime/vm/service.cc
> File runtime/vm/service.cc (right):
> 
>
https://codereview.chromium.org/1690333002/diff/1/runtime/vm/service.cc#newco...
> runtime/vm/service.cc:2873: new EnumListParameter("recordedStreams",
> On 2016/02/12 20:13:57, Cutch wrote:
> > On 2016/02/12 18:57:56, zra wrote:
> > > Where is this deleted?
> > 
> > It's not and none of our parameter lists are.
> 
> If there isn't one already, please file a bug to clean these up and add a
TODO.

Bug #25776 filed.

[Cutch, 2016-02-12 21:18:31]

Description was changed from

==========
Add fine grained command line and service protocol control over timeline streams
recording

- Add --timeline-streams= flag which takes a comma separated list of streams to
record.
- Send "availableStreams" and "recordedStreams" in the _getVMTimelineFlags RPC.
Also include the type of recorder we are using.
- Enable setting of "recordedStreams" in the _setVMTimelineFlags RPC.
==========

to

==========
Add fine grained command line and service protocol control over timeline streams
recording

- Add --timeline-streams= flag which takes a comma separated list of streams to
record.
- Send "availableStreams" and "recordedStreams" in the _getVMTimelineFlags RPC.
Also include the type of recorder we are using.
- Enable setting of "recordedStreams" in the _setVMTimelineFlags RPC.

R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/cda760915c68f7634234127e558100933fac0e49
==========

[Cutch, 2016-02-12 21:18:32]

Committed patchset #2 (id:20001) manually as
cda760915c68f7634234127e558100933fac0e49 (presubmit successful).