Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: runtime/observatory/lib/src/elements/timeline_page.dart

Issue 1690333002: Add fine grained command line and service protocol control over timeline streams recording (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/observatory/tests/service/vm_timeline_flags_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/elements/timeline_page.dart
diff --git a/runtime/observatory/lib/src/elements/timeline_page.dart b/runtime/observatory/lib/src/elements/timeline_page.dart
index 04a7376186b8ef6da0113d23d866be987f92bcce..b7a5462d523befc7b363a11358d9ef8f74d8ee24 100644
--- a/runtime/observatory/lib/src/elements/timeline_page.dart
+++ b/runtime/observatory/lib/src/elements/timeline_page.dart
@@ -57,14 +57,14 @@ class TimelinePageElement extends ObservatoryElement {
}
Future recordOn() async {
- return app.vm.invokeRpc('_setVMTimelineFlag', {
- '_record': 'all',
+ return app.vm.invokeRpc('_setVMTimelineFlags', {
+ 'recordedStreams': ['all'],
});
}
Future recordOff() async {
- return app.vm.invokeRpc('_setVMTimelineFlag', {
- '_record': 'none',
+ return app.vm.invokeRpc('_setVMTimelineFlags', {
+ 'recordedStreams': [],
});
}
« no previous file with comments | « no previous file | runtime/observatory/tests/service/vm_timeline_flags_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698