Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1384)

Issue 1690263003: Improve --trace-service to help track down problems in full_coverage_test. (Closed)

Created:
4 years, 10 months ago by turnidge
Modified:
4 years, 10 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve --trace-service to help track down problems in full_coverage_test. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/2ef7f6f14090acb17ab307f085a8c1760cd37898

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -6 lines) Patch
M runtime/lib/developer.dart View 5 chunks +16 lines, -5 lines 0 comments Download
M runtime/observatory/tests/service/test_helper.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/isolate.cc View 6 chunks +26 lines, -1 line 0 comments Download
M runtime/vm/service_isolate.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
turnidge
4 years, 10 months ago (2016-02-12 21:19:49 UTC) #2
Cutch
lgtm
4 years, 10 months ago (2016-02-12 21:20:53 UTC) #3
turnidge
4 years, 10 months ago (2016-02-12 21:26:02 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2ef7f6f14090acb17ab307f085a8c1760cd37898 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698