Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Side by Side Diff: runtime/observatory/tests/service/test_helper.dart

Issue 1690263003: Improve --trace-service to help track down problems in full_coverage_test. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/lib/developer.dart ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library test_helper; 5 library test_helper;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'dart:convert'; 8 import 'dart:convert';
9 import 'dart:io'; 9 import 'dart:io';
10 import 'package:observatory/service_io.dart'; 10 import 'package:observatory/service_io.dart';
(...skipping 23 matching lines...) Expand all
34 assert(pause_on_start != null); 34 assert(pause_on_start != null);
35 assert(pause_on_exit != null); 35 assert(pause_on_exit != null);
36 assert(trace_service != null); 36 assert(trace_service != null);
37 // TODO(turnidge): I have temporarily turned on service tracing for 37 // TODO(turnidge): I have temporarily turned on service tracing for
38 // all tests to help diagnose flaky tests. 38 // all tests to help diagnose flaky tests.
39 trace_service = true; 39 trace_service = true;
40 String dartExecutable = Platform.executable; 40 String dartExecutable = Platform.executable;
41 var fullArgs = []; 41 var fullArgs = [];
42 if (trace_service) { 42 if (trace_service) {
43 fullArgs.add('--trace-service'); 43 fullArgs.add('--trace-service');
44 fullArgs.add('--trace-service-verbose');
44 } 45 }
45 if (trace_compiler) { 46 if (trace_compiler) {
46 fullArgs.add('--trace-compiler'); 47 fullArgs.add('--trace-compiler');
47 } 48 }
48 if (pause_on_start) { 49 if (pause_on_start) {
49 fullArgs.add('--pause-isolates-on-start'); 50 fullArgs.add('--pause-isolates-on-start');
50 } 51 }
51 if (pause_on_exit) { 52 if (pause_on_exit) {
52 fullArgs.add('--pause-isolates-on-exit'); 53 fullArgs.add('--pause-isolates-on-exit');
53 } 54 }
(...skipping 396 matching lines...) Expand 10 before | Expand all | Expand 10 after
450 }, onError: (e, st) { 451 }, onError: (e, st) {
451 process.requestExit(); 452 process.requestExit();
452 if (!_isWebSocketDisconnect(e)) { 453 if (!_isWebSocketDisconnect(e)) {
453 print('Unexpected exception in service tests: $e $st'); 454 print('Unexpected exception in service tests: $e $st');
454 throw e; 455 throw e;
455 } 456 }
456 }); 457 });
457 }); 458 });
458 } 459 }
459 } 460 }
OLDNEW
« no previous file with comments | « runtime/lib/developer.dart ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698