Issue 169023002: still trying to kill setDevice: rename to setRootDevice (better name) and make private

Issue 169023002: still trying to kill setDevice: rename to setRootDevice (better name) and make private (Closed)

Created:
6 years, 10 months ago by reed2

Modified:
6 years, 10 months ago

Reviewers:
scroggo, bsalomon, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

still trying to kill setDevice: rename to setRootDevice (better name) and make private BUG=skia: COLLABORATOR=reed@google.com Committed: http://code.google.com/p/skia/source/detail?r=13476

Patch Set 1 #

Total comments: 1

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -33 lines)			Patch
M	include/core/SkCanvas.h	View	2 chunks	+10 lines, -11 lines	0 comments	Download
M	src/core/SkCanvas.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/core/SkPictureRecord.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/core/SkPictureRecord.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/image/SkSurface_Gpu.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pipe/SkGPipeWrite.cpp	View	2 chunks	+7 lines, -12 lines	1 comment	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

reed1

looking at the code in SkSurface_Gpu.cpp, we really need to think about how we want ...

6 years, 10 months ago (2014-02-16 21:37:17 UTC) #2

scroggo

lgtm https://codereview.chromium.org/169023002/diff/1/src/pipe/SkGPipeWrite.cpp File src/pipe/SkGPipeWrite.cpp (right): https://codereview.chromium.org/169023002/diff/1/src/pipe/SkGPipeWrite.cpp#newcode428 src/pipe/SkGPipeWrite.cpp:428: : SkCanvas(width, height) nit: INHERITED.

6 years, 10 months ago (2014-02-17 14:40:43 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@chromium.org/169023002/1

6 years, 10 months ago (2014-02-17 14:54:31 UTC) #5

Message was sent while issue was closed.

Change committed as 13476

Expand Messages | Collapse Messages