Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: include/core/SkCanvas.h

Issue 169023002: still trying to kill setDevice: rename to setRootDevice (better name) and make private (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/core/SkCanvas.cpp » ('j') | src/pipe/SkGPipeWrite.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/core/SkCanvas.h
diff --git a/include/core/SkCanvas.h b/include/core/SkCanvas.h
index 684541feb29335f36c4121e96e4d9b2a8f01d4c8..80d46ed9c56de497c8bea924a4dc1b80d9c47469 100644
--- a/include/core/SkCanvas.h
+++ b/include/core/SkCanvas.h
@@ -1085,17 +1085,6 @@ protected:
// can perform copy-on-write or invalidate any cached images
void predrawNotify();
- /**
- DEPRECATED -- need to remove when subclass stop relying on it.
- Marked as 'protected' to avoid new clients using this before we can
- completely remove it.
-
- Specify a device for this canvas to draw into. If it is not null, its
- reference count is incremented. If the canvas was already holding a
- device, its reference count is decremented. The new device is returned.
- */
- virtual SkBaseDevice* setDevice(SkBaseDevice* device);
-
private:
class MCRec;
@@ -1129,6 +1118,16 @@ private:
SkBaseDevice* init(SkBaseDevice*);
+ /**
+ * DEPRECATED
+ *
+ * Specify a device for this canvas to draw into. If it is not null, its
+ * reference count is incremented. If the canvas was already holding a
+ * device, its reference count is decremented. The new device is returned.
+ */
+ SkBaseDevice* setRootDevice(SkBaseDevice* device);
+
+
// internal methods are not virtual, so they can safely be called by other
// canvas apis, without confusing subclasses (like SkPictureRecording)
void internalDrawBitmap(const SkBitmap&, const SkMatrix& m, const SkPaint* paint);
« no previous file with comments | « no previous file | src/core/SkCanvas.cpp » ('j') | src/pipe/SkGPipeWrite.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698