third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp - Issue 1690173003: Canvas2d: Make the intersection computation O(1) instead of O(n) in ClipList.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp

Issue 1690173003: Canvas2d: Make the intersection computation O(1) instead of O(n) in ClipList. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp

diff --git a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp

index e9d29906908580a7a7222f00e6eee45e2a1ec416..74a4b26d14915baa4f78102af9087f8a5441f44f 100644

--- a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp

+++ b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp

@@ -2262,7 +2262,7 @@ void CanvasRenderingContext2D::addHitRegion(const HitRegionOptions& options, Exc

hitRegionPath.transform(state().transform());

if (state().hasClip()) {

- hitRegionPath = state().intersectPathWithClip(hitRegionPath.skPath());

+ hitRegionPath.intersectPath(state().getCurrentClipPath());

if (hitRegionPath.isEmpty())

exceptionState.throwDOMException(NotSupportedError, "The specified path has no pixels.");

}

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.h » ('j') | no next file with comments »