Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp

Issue 1690173003: Canvas2d: Make the intersection computation O(1) instead of O(n) in ClipList. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2010 Nokia Corporation and/or its subsidiary(-ies) 3 * Copyright (C) 2008, 2010 Nokia Corporation and/or its subsidiary(-ies)
4 * Copyright (C) 2007 Alp Toker <alp@atoker.com> 4 * Copyright (C) 2007 Alp Toker <alp@atoker.com>
5 * Copyright (C) 2008 Eric Seidel <eric@webkit.org> 5 * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
6 * Copyright (C) 2008 Dirk Schulze <krit@webkit.org> 6 * Copyright (C) 2008 Dirk Schulze <krit@webkit.org>
7 * Copyright (C) 2010 Torch Mobile (Beijing) Co. Ltd. All rights reserved. 7 * Copyright (C) 2010 Torch Mobile (Beijing) Co. Ltd. All rights reserved.
8 * Copyright (C) 2012, 2013 Intel Corporation. All rights reserved. 8 * Copyright (C) 2012, 2013 Intel Corporation. All rights reserved.
9 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved. 9 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
10 * 10 *
(...skipping 2244 matching lines...) Expand 10 before | Expand all | Expand 10 after
2255 2255
2256 if (hitRegionPath.isEmpty() || !c || !state().isTransformInvertible() 2256 if (hitRegionPath.isEmpty() || !c || !state().isTransformInvertible()
2257 || !c->getClipDeviceBounds(0)) { 2257 || !c->getClipDeviceBounds(0)) {
2258 exceptionState.throwDOMException(NotSupportedError, "The specified path has no pixels."); 2258 exceptionState.throwDOMException(NotSupportedError, "The specified path has no pixels.");
2259 return; 2259 return;
2260 } 2260 }
2261 2261
2262 hitRegionPath.transform(state().transform()); 2262 hitRegionPath.transform(state().transform());
2263 2263
2264 if (state().hasClip()) { 2264 if (state().hasClip()) {
2265 hitRegionPath = state().intersectPathWithClip(hitRegionPath.skPath()); 2265 hitRegionPath.intersectPath(state().getCurrentClipPath());
2266 if (hitRegionPath.isEmpty()) 2266 if (hitRegionPath.isEmpty())
2267 exceptionState.throwDOMException(NotSupportedError, "The specified p ath has no pixels."); 2267 exceptionState.throwDOMException(NotSupportedError, "The specified p ath has no pixels.");
2268 } 2268 }
2269 2269
2270 if (!m_hitRegionManager) 2270 if (!m_hitRegionManager)
2271 m_hitRegionManager = HitRegionManager::create(); 2271 m_hitRegionManager = HitRegionManager::create();
2272 2272
2273 // Remove previous region (with id or control) 2273 // Remove previous region (with id or control)
2274 m_hitRegionManager->removeHitRegionById(options.id()); 2274 m_hitRegionManager->removeHitRegionById(options.id());
2275 m_hitRegionManager->removeHitRegionByControl(options.control().get()); 2275 m_hitRegionManager->removeHitRegionByControl(options.control().get());
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
2370 if (imageType == CanvasRenderingContext2DState::NonOpaqueImage) 2370 if (imageType == CanvasRenderingContext2DState::NonOpaqueImage)
2371 return; 2371 return;
2372 if (alpha < 0xFF) 2372 if (alpha < 0xFF)
2373 return; 2373 return;
2374 } 2374 }
2375 2375
2376 canvas()->buffer()->willOverwriteCanvas(); 2376 canvas()->buffer()->willOverwriteCanvas();
2377 } 2377 }
2378 2378
2379 } // namespace blink 2379 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698