Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1690133004: MIPS: Adjust code after JALR to JAL optimization removal (Closed)

Created:
4 years, 10 months ago by miran.karic
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Adjust code after JALR to JAL optimization removal Now that JALR to JAL optimization is removed, the value of the constant kInstructionsFor32BitConstant and comments are adjusted accordingly. BUG= Committed: https://crrev.com/e3453a866d471e27cb0a7bf9c2196b632bda77fc Cr-Commit-Position: refs/heads/master@{#34235}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M src/mips/assembler-mips.h View 1 chunk +5 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
miran.karic
4 years, 10 months ago (2016-02-12 12:49:56 UTC) #2
akos.palfi.imgtec
LGTM
4 years, 10 months ago (2016-02-19 12:36:40 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690133004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690133004/1
4 years, 10 months ago (2016-02-19 14:47:28 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-19 15:17:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690133004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690133004/1
4 years, 10 months ago (2016-02-24 08:15:14 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-24 08:33:48 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 08:34:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3453a866d471e27cb0a7bf9c2196b632bda77fc
Cr-Commit-Position: refs/heads/master@{#34235}

Powered by Google App Engine
This is Rietveld 408576698