Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/mips/assembler-mips.h

Issue 1690133004: MIPS: Adjust code after JALR to JAL optimization removal (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 500 matching lines...) Expand 10 before | Expand all | Expand 10 after
511 static const int kBranchPCOffset = 4; 511 static const int kBranchPCOffset = 4;
512 512
513 // Here we are patching the address in the LUI/ORI instruction pair. 513 // Here we are patching the address in the LUI/ORI instruction pair.
514 // These values are used in the serialization process and must be zero for 514 // These values are used in the serialization process and must be zero for
515 // MIPS platform, as Code, Embedded Object or External-reference pointers 515 // MIPS platform, as Code, Embedded Object or External-reference pointers
516 // are split across two consecutive instructions and don't exist separately 516 // are split across two consecutive instructions and don't exist separately
517 // in the code, so the serializer should not step forwards in memory after 517 // in the code, so the serializer should not step forwards in memory after
518 // a target is resolved and written. 518 // a target is resolved and written.
519 static const int kSpecialTargetSize = 0; 519 static const int kSpecialTargetSize = 0;
520 520
521 // Number of consecutive instructions used to store 32bit constant. 521 // Number of consecutive instructions used to store 32bit constant. This
522 // Before jump-optimizations, this constant was used in 522 // constant is used in RelocInfo::target_address_address() function to tell
523 // RelocInfo::target_address_address() function to tell serializer address of 523 // serializer address of the instruction that follows LUI/ORI instruction
524 // the instruction that follows LUI/ORI instruction pair. Now, with new jump 524 // pair.
525 // optimization, where jump-through-register instruction that usually 525 static const int kInstructionsFor32BitConstant = 2;
526 // follows LUI/ORI pair is substituted with J/JAL, this constant equals
527 // to 3 instructions (LUI+ORI+J/JAL/JR/JALR).
528 static const int kInstructionsFor32BitConstant = 3;
529 526
530 // Distance between the instruction referring to the address of the call 527 // Distance between the instruction referring to the address of the call
531 // target and the return address. 528 // target and the return address.
532 static const int kCallTargetAddressOffset = 4 * kInstrSize; 529 static const int kCallTargetAddressOffset = 4 * kInstrSize;
533 530
534 // Distance between start of patched debug break slot and the emitted address 531 // Distance between start of patched debug break slot and the emitted address
535 // to jump to. 532 // to jump to.
536 static const int kPatchDebugBreakSlotAddressOffset = 4 * kInstrSize; 533 static const int kPatchDebugBreakSlotAddressOffset = 4 * kInstrSize;
537 534
538 // Difference between address of current opcode and value read from pc 535 // Difference between address of current opcode and value read from pc
(...skipping 899 matching lines...) Expand 10 before | Expand all | Expand 10 after
1438 public: 1435 public:
1439 explicit EnsureSpace(Assembler* assembler) { 1436 explicit EnsureSpace(Assembler* assembler) {
1440 assembler->CheckBuffer(); 1437 assembler->CheckBuffer();
1441 } 1438 }
1442 }; 1439 };
1443 1440
1444 } // namespace internal 1441 } // namespace internal
1445 } // namespace v8 1442 } // namespace v8
1446 1443
1447 #endif // V8_ARM_ASSEMBLER_MIPS_H_ 1444 #endif // V8_ARM_ASSEMBLER_MIPS_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698