Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 1690053002: Revert of Make copySurface work for texture dsts, return a bool, & add unit test. (Closed)

Created:
4 years, 10 months ago by kjlubick
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Make copySurface work for texture dsts, return a bool, & add unit test. (patchset #6 id:100001 of https://codereview.chromium.org/1684313002/ ) Reason for revert: Copy surface tests are not happy for Windows, Android and probably others: https://uberchromegw.corp.google.com/i/client.skia.android/builders/Test-Android-GCC-Nexus7-GPU-Tegra3-Arm7-Release/builds/4161 https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Win8-MSVC-ShuttleA-GPU-GTX960-x86_64-Release/builds/3694 Original issue's description: > Make copySurface work for texture dsts, return a bool, & add unit test. > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1684313002 > > Committed: https://skia.googlesource.com/skia/+/7ea5e28065e5eb797e95f5d81c1a65cf3209d741 TBR=robertphillips@google.com,bsalomon@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/0eed945294fa0b2dee7d971c16dc9beefab2ec1c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -233 lines) Patch
M include/gpu/GrContext.h View 1 chunk +12 lines, -5 lines 0 comments Download
M include/gpu/GrDrawContext.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrContext.cpp View 2 chunks +18 lines, -27 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 chunk +8 lines, -10 lines 0 comments Download
M src/gpu/SkGrPixelRef.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/batches/GrCopySurfaceBatch.h View 1 chunk +0 lines, -10 lines 0 comments Download
M src/gpu/batches/GrCopySurfaceBatch.cpp View 2 chunks +12 lines, -7 lines 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 chunk +1 line, -2 lines 0 comments Download
D tests/CopySurfaceTest.cpp View 1 chunk +0 lines, -163 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
kjlubick
Created Revert of Make copySurface work for texture dsts, return a bool, & add unit ...
4 years, 10 months ago (2016-02-11 20:05:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690053002/1
4 years, 10 months ago (2016-02-11 20:05:19 UTC) #2
commit-bot: I haz the power
4 years, 10 months ago (2016-02-11 20:05:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0eed945294fa0b2dee7d971c16dc9beefab2ec1c

Powered by Google App Engine
This is Rietveld 408576698