Make copySurface work for texture dsts, return a bool, & add unit test.

Make copySurface work for texture dsts, return a bool, & add unit test.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1684313002

Committed: https://skia.googlesource.com/skia/+/7ea5e28065e5eb797e95f5d81c1a65cf3209d741

Committed: https://skia.googlesource.com/skia/+/b8fea97a7a493897fcff33aa2932d875c572f163

[bsalomon, 2016-02-10 22:23:20]

Description was changed from

==========
Start of copySurface improvements, test

BUG=skia:
==========

to

==========
Start of copySurface improvements, test

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-02-11 16:37:36]

Description was changed from

==========
Start of copySurface improvements, test

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Make copySurface work for texture dsts, return a bool, & add unit test.
==========

[bsalomon, 2016-02-11 16:37:36]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[robertphillips, 2016-02-11 18:31:29]

lgtm

https://codereview.chromium.org/1684313002/diff/40001/tests/CopySurfaceTest.cpp
File tests/CopySurfaceTest.cpp (right):

https://codereview.chromium.org/1684313002/diff/40001/tests/CopySurfaceTest.c...
tests/CopySurfaceTest.cpp:32: SkAutoTMalloc<uint32_t> dstPixels(kW * kH);
Is this memset useful ?

[bsalomon, 2016-02-11 18:47:11]

Description was changed from

==========
Make copySurface work for texture dsts, return a bool, & add unit test.
==========

to

==========
Make copySurface work for texture dsts, return a bool, & add unit test.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-02-11 18:49:11]

https://codereview.chromium.org/1684313002/diff/40001/tests/CopySurfaceTest.cpp
File tests/CopySurfaceTest.cpp (right):

https://codereview.chromium.org/1684313002/diff/40001/tests/CopySurfaceTest.c...
tests/CopySurfaceTest.cpp:32: SkAutoTMalloc<uint32_t> dstPixels(kW * kH);
On 2016/02/11 18:31:29, robertphillips wrote:
> Is this memset useful ?

Nope, leftover from earlier iteration of this test.

[bsalomon, 2016-02-11 18:49:14]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-02-11 18:49:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1684313002/#ps60001
(title: "remove unneeded memset")

[commit-bot: I haz the power, 2016-02-11 18:49:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1684313002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1684313002/60001

[commit-bot: I haz the power, 2016-02-11 18:50:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-11 18:50:28]

Try jobs failed on following builders:
  Build-Mac-Clang-Arm7-Debug-iOS-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-Arm7...)

[bsalomon, 2016-02-11 19:00:51]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-02-11 19:00:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1684313002/#ps80001
(title: "include <initializer_list>")

[commit-bot: I haz the power, 2016-02-11 19:01:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1684313002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1684313002/80001

[commit-bot: I haz the power, 2016-02-11 19:02:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-11 19:02:53]

Try jobs failed on following builders:
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[bsalomon, 2016-02-11 19:07:53]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-02-11 19:07:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1684313002/#ps100001
(title: "fix uninit warning")

[commit-bot: I haz the power, 2016-02-11 19:07:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1684313002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1684313002/100001

[commit-bot: I haz the power, 2016-02-11 19:42:34]

Description was changed from

==========
Make copySurface work for texture dsts, return a bool, & add unit test.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Make copySurface work for texture dsts, return a bool, & add unit test.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/7ea5e28065e5eb797e95f5d81c1a65cf3209d741
==========

[commit-bot: I haz the power, 2016-02-11 19:42:35]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/7ea5e28065e5eb797e95f5d81c1a65cf3209d741

[kjlubick, 2016-02-11 20:05:09]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1690053002/ by kjlubick@google.com.

The reason for reverting is: Copy surface tests are not happy for Windows,
Android and probably others:
https://uberchromegw.corp.google.com/i/client.skia.android/builders/Test-Andr...
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Win8-MSVC-Sh....

[bsalomon, 2016-02-12 20:12:15]

Description was changed from

==========
Make copySurface work for texture dsts, return a bool, & add unit test.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/7ea5e28065e5eb797e95f5d81c1a65cf3209d741
==========

to

==========
Make copySurface work for texture dsts, return a bool, & add unit test.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/7ea5e28065e5eb797e95f5d81c1a65cf3209d741
==========

[bsalomon, 2016-02-16 15:08:07]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-02-16 15:08:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1684313002/#ps120001
(title: "try again")

[commit-bot: I haz the power, 2016-02-16 15:08:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1684313002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1684313002/120001

[commit-bot: I haz the power, 2016-02-16 15:34:19]

Description was changed from

==========
Make copySurface work for texture dsts, return a bool, & add unit test.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/7ea5e28065e5eb797e95f5d81c1a65cf3209d741
==========

to

==========
Make copySurface work for texture dsts, return a bool, & add unit test.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/7ea5e28065e5eb797e95f5d81c1a65cf3209d741

Committed:
https://skia.googlesource.com/skia/+/b8fea97a7a493897fcff33aa2932d875c572f163
==========

[commit-bot: I haz the power, 2016-02-16 15:34:20]

Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/b8fea97a7a493897fcff33aa2932d875c572f163