Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1689633002: Finally get rid of depot_tools' breakpad. (Closed)

Created:
4 years, 10 months ago by tandrii(chromium)
Modified:
4 years, 10 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Finally get rid of depot_tools' breakpad. R=maruel@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298710

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -304 lines) Patch
M apply_issue.py View 1 chunk +0 lines, -1 line 0 comments Download
D breakpad.py View 1 chunk +0 lines, -147 lines 0 comments Download
M commit_queue.py View 1 chunk +0 lines, -2 lines 0 comments Download
M drover.py View 3 chunks +2 lines, -3 lines 0 comments Download
M gcl.py View 2 chunks +0 lines, -8 lines 0 comments Download
M gclient.py View 1 chunk +0 lines, -2 lines 0 comments Download
M git_cl.py View 2 chunks +0 lines, -7 lines 0 comments Download
M git_try.py View 1 chunk +0 lines, -2 lines 0 comments Download
D tests/breakpad_unittest.py View 1 chunk +0 lines, -123 lines 0 comments Download
M tests/git_cl_test.py View 1 2 chunks +0 lines, -6 lines 0 comments Download
M tests/trychange_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M trychange.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689633002/1
4 years, 10 months ago (2016-02-10 14:07:49 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/depot_tools_presubmit/builds/449)
4 years, 10 months ago (2016-02-10 14:15:58 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689633002/20001
4 years, 10 months ago (2016-02-10 16:29:27 UTC) #6
tandrii(chromium)
PTAL
4 years, 10 months ago (2016-02-10 16:32:42 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-10 16:32:45 UTC) #9
M-A Ruel
lgtm
4 years, 10 months ago (2016-02-10 16:34:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689633002/20001
4 years, 10 months ago (2016-02-10 16:38:06 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=298710
4 years, 10 months ago (2016-02-10 16:40:13 UTC) #14
Nico
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1683173002/ by thakis@chromium.org. ...
4 years, 10 months ago (2016-02-10 16:51:25 UTC) #15
sdefresne
On 2016/02/10 at 16:40:13, commit-bot wrote: > Committed patchset #2 (id:20001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=298710 This broke ...
4 years, 10 months ago (2016-02-10 16:52:24 UTC) #16
Dirk Pranke
I'm even confused as to why we would do this. Do we think breakpad is ...
4 years, 10 months ago (2016-02-10 17:12:35 UTC) #17
M-A Ruel
On 2016/02/10 17:12:35, Dirk Pranke wrote: > I'm even confused as to why we would ...
4 years, 10 months ago (2016-02-10 17:22:49 UTC) #18
Dirk Pranke
On 2016/02/10 17:22:49, M-A Ruel wrote: > On 2016/02/10 17:12:35, Dirk Pranke wrote: > > ...
4 years, 10 months ago (2016-02-10 17:25:56 UTC) #19
tandrii(chromium)
On 2016/02/10 17:12:35, Dirk Pranke wrote: > I'm even confused as to why we would ...
4 years, 10 months ago (2016-02-10 17:28:43 UTC) #20
tandrii(chromium)
On 2016/02/10 17:28:43, tandrii(chromium) wrote: > On 2016/02/10 17:12:35, Dirk Pranke wrote: > > I'm ...
4 years, 10 months ago (2016-02-10 17:29:15 UTC) #21
tandrii(chromium)
4 years, 10 months ago (2016-02-10 17:29:15 UTC) #22
Message was sent while issue was closed.
On 2016/02/10 17:28:43, tandrii(chromium) wrote:
> On 2016/02/10 17:12:35, Dirk Pranke wrote:
> > I'm even confused as to why we would do this. Do we think breakpad is no
> longer
> > useful?
> 
> Because nobody checks its stack traces anyway, though there are also good
> privacy concerns for people naming their machine hosts as *.google.com or
> *.chromium.org.

and i filed a bug http://crbug.com/585837

Powered by Google App Engine
This is Rietveld 408576698