git_cl.py - Issue 1689633002: Finally get rid of depot_tools' breakpad.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: git_cl.py

Issue 1689633002: Finally get rid of depot_tools' breakpad. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: fix test Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: git_cl.py

diff --git a/git_cl.py b/git_cl.py

index 5b5872bbd0db18d96faaeabdd00033d8a13aac8b..46e60fb203b1abca7fb267b1d16956757d91121f 100755

--- a/git_cl.py

+++ b/git_cl.py

@@ -40,7 +40,6 @@ from third_party import httplib2

from third_party import upload

import auth

from luci_hacks import trigger_luci_job as luci_trigger

-import breakpad # pylint: disable=W0611

import clang_format

import commit_queue

import dart_format

@@ -2619,12 +2618,6 @@ def SendUpstream(parser, args, cmd):

print('Unable to determine tree status. Please verify manually and '

'use "git cl %s --bypass-hooks" to commit on a closed tree.' % cmd)

return 1

- else:

- breakpad.SendStack(

- 'GitClHooksBypassedCommit',

- 'Issue %s/%s bypassed hook when committing (tree status was "%s")' %

- (cl.GetRietveldServer(), cl.GetIssue(), GetTreeStatus()),

- verbose=False)

change_desc = ChangeDescription(options.message)

if not change_desc.description and cl.GetIssue():

« no previous file with comments | « gclient.py ('k') | git_try.py » ('j') | no next file with comments »