Source/modules/speech/SpeechRecognitionResultList.h - Issue 168963003: Make WebPrivatePtr capable of wrapping garbage collected objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/speech/SpeechRecognitionResultList.h

Issue 168963003: Make WebPrivatePtr capable of wrapping garbage collected objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Temporarily drop back to using .reset() instead of nullptr. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/speech/SpeechRecognitionResult.cpp ('k') | Source/modules/speech/SpeechRecognitionResultList.cpp » ('j') | public/platform/WebPrivatePtr.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/speech/SpeechRecognitionResultList.h

diff --git a/Source/modules/speech/SpeechRecognitionResultList.h b/Source/modules/speech/SpeechRecognitionResultList.h

index f209370a86c575959f731cca1c78dd33d294bcbc..518ce33375c97dd76ff2ca7fd68893db9e2099e5 100644

--- a/Source/modules/speech/SpeechRecognitionResultList.h

+++ b/Source/modules/speech/SpeechRecognitionResultList.h

@@ -37,7 +37,7 @@ namespace WebCore {

class SpeechRecognitionResultList : public RefCountedWillBeGarbageCollectedFinalized<SpeechRecognitionResultList>, public ScriptWrappable {

DECLARE_GC_INFO;

public:

- static PassRefPtrWillBeRawPtr<SpeechRecognitionResultList> create(const Vector<RefPtr<SpeechRecognitionResult> >&);

+ static PassRefPtrWillBeRawPtr<SpeechRecognitionResultList> create(const WillBeHeapVector<RefPtrWillBeMember<SpeechRecognitionResult> >&);

unsigned long length() { return m_results.size(); }

SpeechRecognitionResult* item(unsigned long index);

@@ -45,7 +45,7 @@ public:

void trace(Visitor*);

private:

- explicit SpeechRecognitionResultList(const Vector<RefPtr<SpeechRecognitionResult> >&);

+ explicit SpeechRecognitionResultList(const WillBeHeapVector<RefPtrWillBeMember<SpeechRecognitionResult> >&);

WillBeHeapVector<RefPtrWillBeMember<SpeechRecognitionResult> > m_results;

};