Source/modules/speech/SpeechRecognitionResult.cpp - Issue 168963003: Make WebPrivatePtr capable of wrapping garbage collected objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/speech/SpeechRecognitionResult.cpp

Issue 168963003: Make WebPrivatePtr capable of wrapping garbage collected objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Temporarily drop back to using .reset() instead of nullptr. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/speech/SpeechRecognitionResult.h ('k') | Source/modules/speech/SpeechRecognitionResultList.h » ('j') | public/platform/WebPrivatePtr.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/speech/SpeechRecognitionResult.cpp

diff --git a/Source/modules/speech/SpeechRecognitionResult.cpp b/Source/modules/speech/SpeechRecognitionResult.cpp

index 09c58590db27c29bda8a79d585789d7d46963d22..6be2c551013fcefc53a518c55629ec449ca51f94 100644

--- a/Source/modules/speech/SpeechRecognitionResult.cpp

+++ b/Source/modules/speech/SpeechRecognitionResult.cpp

@@ -35,9 +35,9 @@ SpeechRecognitionResult::~SpeechRecognitionResult()

{

}

-PassRefPtr<SpeechRecognitionResult> SpeechRecognitionResult::create(const WillBeHeapVector<RefPtrWillBeMember<SpeechRecognitionAlternative> >& alternatives, bool final)

+PassRefPtrWillBeRawPtr<SpeechRecognitionResult> SpeechRecognitionResult::create(const WillBeHeapVector<RefPtrWillBeMember<SpeechRecognitionAlternative> >& alternatives, bool final)

{

- return adoptRef(new SpeechRecognitionResult(alternatives, final));

+ return adoptRefWillBeNoop(new SpeechRecognitionResult(alternatives, final));

}

SpeechRecognitionAlternative* SpeechRecognitionResult::item(unsigned long index)

« no previous file with comments | « Source/modules/speech/SpeechRecognitionResult.h ('k') | Source/modules/speech/SpeechRecognitionResultList.h » ('j') | public/platform/WebPrivatePtr.h » ('J')