Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: public/web/WebSpeechGrammar.h

Issue 168963003: Make WebPrivatePtr capable of wrapping garbage collected objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Make WebSpeechGrammar use WebPrivateGarbageCollectedPtr<> Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/web/WebSpeechGrammar.h
diff --git a/public/web/WebSpeechGrammar.h b/public/web/WebSpeechGrammar.h
index 6c6f1379fd070ac47e8d310a5981e5e8d47fa983..71defe2d59708f4ba377cb854b69b8128c9f10c5 100644
--- a/public/web/WebSpeechGrammar.h
+++ b/public/web/WebSpeechGrammar.h
@@ -27,7 +27,7 @@
#define WebSpeechGrammar_h
#include "../platform/WebCommon.h"
-#include "../platform/WebPrivatePtr.h"
+#include "../platform/WebPrivateGarbageCollectedPtr.h"
sof 2014/02/17 11:36:25 checkdeps didn't like this #include, I don't yet u
#include "../platform/WebURL.h"
namespace WebCore {
@@ -49,12 +49,12 @@ public:
BLINK_EXPORT void assign(const WebSpeechGrammar&);
#if BLINK_IMPLEMENTATION
- WebSpeechGrammar(const WTF::PassRefPtr<WebCore::SpeechGrammar>&);
- WebSpeechGrammar& operator=(const WTF::PassRefPtr<WebCore::SpeechGrammar>&);
+ WebSpeechGrammar(const WTF::PassRefPtrWillBeRawPtr<WebCore::SpeechGrammar>&);
haraken 2014/02/17 11:35:58 Add explicit.
sof 2014/02/17 11:44:18 Done.
+ WebSpeechGrammar& operator=(const WTF::PassRefPtrWillBeRawPtr<WebCore::SpeechGrammar>&);
haraken 2014/02/17 11:35:58 Ditto.
sof 2014/02/17 11:44:18 Need to wait for C++11? (Or do we have a condition
haraken 2014/02/17 11:45:16 Sorry, ignore my comment :)
#endif
private:
- WebPrivatePtr<WebCore::SpeechGrammar> m_private;
+ WebPrivateGarbageCollectedPtr<WebCore::SpeechGrammar> m_private;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698