Make WebPrivatePtr capable of wrapping garbage collected objects.

public/web/WebSpeechGrammar.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *  * Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  *  * Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
  *    documentation and/or other materials provided with the distribution.
  *
  * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS ``AS IS'' AND ANY
  * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
  * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
  * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL THE COPYRIGHT OWNER OR
  * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
  * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
  * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
  * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
  * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef WebSpeechGrammar_h
 #define WebSpeechGrammar_h
 
 #include "../platform/WebCommon.h"
-#include "../platform/WebPrivatePtr.h"
+#include "../platform/WebPrivateGarbageCollectedPtr.h"

[sof, 2014/02/17 11:36:25]

checkdeps didn't like this #include, I don't yet understand why.

Needs to be addressed.

 #include "../platform/WebURL.h"
 
 namespace WebCore {
 class SpeechGrammar;
 }
 
 namespace blink {
 
 class WebSpeechGrammar {
 public:
     WebSpeechGrammar() { }
     WebSpeechGrammar(const WebSpeechGrammar& grammar) { assign(grammar); }
     ~WebSpeechGrammar() { reset(); }
 
     BLINK_EXPORT WebURL src() const;
     BLINK_EXPORT float weight() const;
 
     BLINK_EXPORT void reset();
     BLINK_EXPORT void assign(const WebSpeechGrammar&);
 
 #if BLINK_IMPLEMENTATION
-    WebSpeechGrammar(const WTF::PassRefPtr<WebCore::SpeechGrammar>&);
-    WebSpeechGrammar& operator=(const WTF::PassRefPtr<WebCore::SpeechGrammar>&);
+    WebSpeechGrammar(const WTF::PassRefPtrWillBeRawPtr<WebCore::SpeechGrammar>&);

[haraken, 2014/02/17 11:35:58]

Add explicit.

[sof, 2014/02/17 11:44:18]

Done.

+    WebSpeechGrammar& operator=(const WTF::PassRefPtrWillBeRawPtr<WebCore::SpeechGrammar>&);

[haraken, 2014/02/17 11:35:58]

Ditto.

[sof, 2014/02/17 11:44:18]

Need to wait for C++11? (Or do we have a conditional macro for utilizing its
features?)

[haraken, 2014/02/17 11:45:16]

Sorry, ignore my comment :)

 #endif
 
 private:
-    WebPrivatePtr<WebCore::SpeechGrammar> m_private;
+    WebPrivateGarbageCollectedPtr<WebCore::SpeechGrammar> m_private;
 };
 
 } // namespace blink
 
 #endif // WebSpeechGrammar_h