Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 16896018: Enable high resolution time for TimeTicks::Now on Windows Canary (Closed)

Created:
7 years, 6 months ago by James Simonsen
Modified:
7 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, jam
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Enable high resolution time for TimeTicks::Now on Windows Canary This should be unnoticeable, except for improved resolution in places such as window.performance.now(). The feature is enabled if the user is running Canary channel or has manually specified the --enable-high-resolution-time flag. This will only work if the CPU has a non-stop TSC and isn't a broken Athlon processor. UMA data show this is a safe combination. The flag is propagated to renderer processes so that they know to enable it too. BUG=158234 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217172

Patch Set 1 #

Patch Set 2 : Enable on canary and with --enable-high-resolution-time #

Patch Set 3 : Rebase #

Patch Set 4 : Fix TrackedTime #

Total comments: 6

Patch Set 5 : Rename #

Patch Set 6 : Rename (retry) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -6 lines) Patch
M base/profiler/tracked_time.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M base/test/test_suite.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M base/time/time.h View 1 2 3 4 1 chunk +11 lines, -0 lines 0 comments Download
M base/time/time_win.cc View 1 2 3 4 5 chunks +44 lines, -4 lines 0 comments Download
M chrome/browser/chrome_browser_main_win.cc View 1 2 3 4 2 chunks +16 lines, -0 lines 0 comments Download
M content/app/content_main_runner.cc View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/browser_child_process_host_impl.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
James Simonsen
7 years, 4 months ago (2013-08-09 23:00:21 UTC) #1
darin (slow to review)
LGTM https://codereview.chromium.org/16896018/diff/14001/base/time/time.h File base/time/time.h (right): https://codereview.chromium.org/16896018/diff/14001/base/time/time.h#newcode580 base/time/time.h:580: // calls to TimeTicksNow() will have the higher ...
7 years, 4 months ago (2013-08-12 18:57:36 UTC) #2
James Simonsen
https://codereview.chromium.org/16896018/diff/14001/base/time/time.h File base/time/time.h (right): https://codereview.chromium.org/16896018/diff/14001/base/time/time.h#newcode580 base/time/time.h:580: // calls to TimeTicksNow() will have the higher resolution ...
7 years, 4 months ago (2013-08-12 22:57:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonjam@chromium.org/16896018/28001
7 years, 4 months ago (2013-08-12 23:00:29 UTC) #4
commit-bot: I haz the power
7 years, 4 months ago (2013-08-13 02:46:03 UTC) #5
Message was sent while issue was closed.
Change committed as 217172

Powered by Google App Engine
This is Rietveld 408576698