Keep the size button pressed when the user hovers the snap left or snap right button

This CL keeps the alternate style size button pressed during a drag when:
- the user has dragged to the snap left / snap right buttons
- the user has dragged back to the size button

BUG=344411
TEST=AlternateFrameSizeButtonTest.*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252859

[pkotwicz, 2014-02-18 01:32:57]

James, can you please take a look?

The specs are in comment #3 for http://crbug.com/297187
v2/_specs/Apps top bar/cros-apps-toolbar-specs.png

[James Cook, 2014-02-18 19:35:45]

This will have to wait until later today or tomorrow - I have 3 release-blockers
assigned to me this morning and I need to sort those out first.

[James Cook, 2014-02-19 00:31:27]

LGTM with a couple optional nits

https://codereview.chromium.org/168943006/diff/30001/ash/wm/caption_buttons/a...
File ash/wm/caption_buttons/alternate_frame_size_button_unittest.cc (right):

https://codereview.chromium.org/168943006/diff/30001/ash/wm/caption_buttons/a...
ash/wm/caption_buttons/alternate_frame_size_button_unittest.cc:382:
EXPECT_EQ(CAPTION_BUTTON_ICON_RIGHT_SNAPPED, close_button()->icon());
optional nit: This block of assertions seems covered by the test above. You
could skip it and just do the MoveMouseTo() below.  Or keep it if you think the
test is clearer with it.

https://codereview.chromium.org/168943006/diff/30001/ash/wm/caption_buttons/f...
File ash/wm/caption_buttons/frame_caption_button_container_view.cc (right):

https://codereview.chromium.org/168943006/diff/30001/ash/wm/caption_buttons/f...
ash/wm/caption_buttons/frame_caption_button_container_view.cc:7: #include
<math.h>
optional nit: I think we prefer <cmath>, though we seem to use both

[pkotwicz, 2014-02-23 01:07:58]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-02-23 01:08:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/168943006/90007

[commit-bot: I haz the power, 2014-02-23 01:44:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-23 01:44:36]

Retried try job too often on win_rel for step(s) base_unittests, browser_tests,
interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[pkotwicz, 2014-02-23 02:23:33]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-02-23 02:23:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/168943006/360001

[commit-bot: I haz the power, 2014-02-23 04:16:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-23 04:16:24]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[pkotwicz, 2014-02-23 06:25:13]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-02-23 06:25:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/168943006/360001

[commit-bot: I haz the power, 2014-02-23 12:15:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/168943006/360001

[commit-bot: I haz the power, 2014-02-23 12:15:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-23 12:15:32]

Failed to request the patch to try. Please note that binary files are still
unsupported at the moment, this is being worked on.

Thanks for your patience.

The read operation timed out

[pkotwicz, 2014-02-23 19:05:17]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-02-23 19:05:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/168943006/360001

[commit-bot: I haz the power, 2014-02-23 21:57:38]

Change committed as 252859