Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1689113004: Reland of [interpreter] Correctly thread through catch prediction. (Closed)

Created:
4 years, 10 months ago by Michael Starzinger
Modified:
4 years, 10 months ago
Reviewers:
rmcilroy, Yang, adamk
CC:
v8-reviews_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of [interpreter] Correctly thread through catch prediction. (patchset #1 id:1 of https://codereview.chromium.org/1695613002/ ) Reason for revert: No fix needed, original CL was perfectly fine! Original issue's description: > Revert of [interpreter] Correctly thread through catch prediction. (patchset #1 id:1 of https://codereview.chromium.org/1690973002/ ) > > Reason for revert: > Depends on the reverted https://codereview.chromium.org/1691723002 > > Original issue's description: > > [interpreter] Correctly thread through catch prediction. > > > > This change correctly sets the {CatchPrediction} field in exception > > handler tables for bytecode and optimized code. It also adds tests > > independent of promise handling for this prediction, to ensure all our > > backends are in sync on their prediction. > > > > R=rmcilroy@chromium.org,yangguo@chromium.org > > TEST=mjsunit/compiler/debug-catch-prediction > > BUG=v8:4674 > > LOG=n > > > > Committed: https://crrev.com/ba55f5594cb0b4a1a1e9b35d87fe54afe2d93f3b > > Cr-Commit-Position: refs/heads/master@{#33906} > > TBR=rmcilroy@chromium.org,yangguo@chromium.org,mstarzinger@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4674 > > Committed: https://crrev.com/c5229b311968fd638a6cd537c341b1055eb7be97 > Cr-Commit-Position: refs/heads/master@{#33922} TBR=rmcilroy@chromium.org,yangguo@chromium.org,adamk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4674 Committed: https://crrev.com/5bbcdfe6800c70b594a78c499cf420b875989449 Cr-Commit-Position: refs/heads/master@{#33933}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -10 lines) Patch
M src/compiler/bytecode-graph-builder.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M src/interpreter/bytecode-generator.h View 2 chunks +6 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 4 chunks +16 lines, -4 lines 0 comments Download
M src/interpreter/control-flow-builders.h View 2 chunks +8 lines, -2 lines 0 comments Download
M src/interpreter/control-flow-builders.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +6 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/debug-catch-prediction.js View 1 chunk +143 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Starzinger
Created Reland of [interpreter] Correctly thread through catch prediction.
4 years, 10 months ago (2016-02-12 09:51:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689113004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689113004/1
4 years, 10 months ago (2016-02-12 09:51:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-12 09:51:58 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-02-12 09:52:33 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5bbcdfe6800c70b594a78c499cf420b875989449
Cr-Commit-Position: refs/heads/master@{#33933}

Powered by Google App Engine
This is Rietveld 408576698