Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1689113002:
[regexp] ship unicode regexps. (Closed)
Description[regexp] ship unicode regexps.
R=rossberg@chromium.org
BUG=v8:2952
LOG=N
Committed: https://crrev.com/3a2fbc3a4ed2802b52659df2209b930200d63b29
Cr-Commit-Position: refs/heads/master@{#33899}
Committed: https://crrev.com/e1c645d1f41febae014b4d0dfe7dc6e4549fab5e
Cr-Commit-Position: refs/heads/master@{#33927}
Patch Set 1 #Patch Set 2 : rebase #
Messages
Total messages: 30 (13 generated)
The CQ bit was checked by yangguo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689113002/1
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yangguo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689113002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [regexp] ship unicode regexps. R=rossberg@chromium.org BUG=v8:2952 LOG=N ========== to ========== [regexp] ship unicode regexps. R=rossberg@chromium.org BUG=v8:2952 LOG=N Committed: https://crrev.com/3a2fbc3a4ed2802b52659df2209b930200d63b29 Cr-Commit-Position: refs/heads/master@{#33899} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/3a2fbc3a4ed2802b52659df2209b930200d63b29 Cr-Commit-Position: refs/heads/master@{#33899}
Message was sent while issue was closed.
Can that cause these failures? https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/...
Message was sent while issue was closed.
Or rather this I guess? https://codereview.chromium.org/1688163003
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1688803005/ by machenbach@chromium.org. The reason for reverting is: [Sheriff] Speculative revert for gc stress failures: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/... Blamelists are screwed up currently....
Message was sent while issue was closed.
Description was changed from ========== [regexp] ship unicode regexps. R=rossberg@chromium.org BUG=v8:2952 LOG=N Committed: https://crrev.com/3a2fbc3a4ed2802b52659df2209b930200d63b29 Cr-Commit-Position: refs/heads/master@{#33899} ========== to ========== [regexp] ship unicode regexps. R=rossberg@chromium.org BUG=v8:2952 LOG=N Committed: https://crrev.com/3a2fbc3a4ed2802b52659df2209b930200d63b29 Cr-Commit-Position: refs/heads/master@{#33899} ==========
The CQ bit was checked by yangguo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689113002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/10853)
The CQ bit was checked by yangguo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rossberg@chromium.org Link to the patchset: https://codereview.chromium.org/1689113002/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689113002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Failed to request the patch to try. Please note that binary files are still unsupported at the moment, this is being worked on. Thanks for your patience. Transient error: No JSON object could be decoded
The CQ bit was checked by yangguo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689113002/20001
Message was sent while issue was closed.
Description was changed from ========== [regexp] ship unicode regexps. R=rossberg@chromium.org BUG=v8:2952 LOG=N Committed: https://crrev.com/3a2fbc3a4ed2802b52659df2209b930200d63b29 Cr-Commit-Position: refs/heads/master@{#33899} ========== to ========== [regexp] ship unicode regexps. R=rossberg@chromium.org BUG=v8:2952 LOG=N Committed: https://crrev.com/3a2fbc3a4ed2802b52659df2209b930200d63b29 Cr-Commit-Position: refs/heads/master@{#33899} ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [regexp] ship unicode regexps. R=rossberg@chromium.org BUG=v8:2952 LOG=N Committed: https://crrev.com/3a2fbc3a4ed2802b52659df2209b930200d63b29 Cr-Commit-Position: refs/heads/master@{#33899} ========== to ========== [regexp] ship unicode regexps. R=rossberg@chromium.org BUG=v8:2952 LOG=N Committed: https://crrev.com/3a2fbc3a4ed2802b52659df2209b930200d63b29 Cr-Commit-Position: refs/heads/master@{#33899} Committed: https://crrev.com/e1c645d1f41febae014b4d0dfe7dc6e4549fab5e Cr-Commit-Position: refs/heads/master@{#33927} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/e1c645d1f41febae014b4d0dfe7dc6e4549fab5e Cr-Commit-Position: refs/heads/master@{#33927} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
