Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1688163003: [regexp] Fix RegExp.prototype.toString. (Closed)

Created:
4 years, 10 months ago by Yang
Modified:
4 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Fix RegExp.prototype.toString. Initial fix was simply wrong. R=verwaest@chromium.org BUG=v8:4524 LOG=N Committed: https://crrev.com/269840c4967d220cb8b011cbe073ba45bdeddb81 Cr-Commit-Position: refs/heads/master@{#33896}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M src/js/regexp.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/regexp-tostring.js View 3 chunks +4 lines, -4 lines 0 comments Download
M test/mjsunit/regexp.js View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
4 years, 10 months ago (2016-02-11 12:42:13 UTC) #1
Toon Verwaest
doh :) lgtm
4 years, 10 months ago (2016-02-11 12:50:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688163003/1
4 years, 10 months ago (2016-02-11 12:51:19 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 13:22:54 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-11 13:23:30 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/269840c4967d220cb8b011cbe073ba45bdeddb81
Cr-Commit-Position: refs/heads/master@{#33896}

Powered by Google App Engine
This is Rietveld 408576698