mojo/edk/system/data_pipe_consumer_dispatcher.cc - Issue 1689053003: Support read-only duplicates of Mojo shared buffers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/edk/system/data_pipe_consumer_dispatcher.cc

Issue 1689053003: Support read-only duplicates of Mojo shared buffers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-shm-interop

Patch Set: Rebase and fix comment. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/edk/system/data_pipe_consumer_dispatcher.cc

diff --git a/mojo/edk/system/data_pipe_consumer_dispatcher.cc b/mojo/edk/system/data_pipe_consumer_dispatcher.cc

index f978f9498e99f921123eceabe6d2a20290d737ee..7bf0b0177acdbd0a2a86891d6f6473cbbfab6752 100644

--- a/mojo/edk/system/data_pipe_consumer_dispatcher.cc

+++ b/mojo/edk/system/data_pipe_consumer_dispatcher.cc

@@ -403,6 +403,7 @@ DataPipeConsumerDispatcher::Deserialize(const void* data,

scoped_refptr<PlatformSharedBuffer> ring_buffer =

PlatformSharedBuffer::CreateFromPlatformHandle(

state->options.capacity_num_bytes,

+ false /* read_only */,

ScopedPlatformHandle(buffer_handle));

if (!ring_buffer) {

DLOG(ERROR) << "Failed to deserialize shared buffer handle.";

« no previous file with comments | « mojo/edk/system/core.cc ('k') | mojo/edk/system/data_pipe_producer_dispatcher.cc » ('j') | no next file with comments »