mojo/edk/system/core.cc - Issue 1689053003: Support read-only duplicates of Mojo shared buffers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/edk/system/core.cc

Issue 1689053003: Support read-only duplicates of Mojo shared buffers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-shm-interop

Patch Set: Rebase and fix comment. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/edk/system/core.cc

diff --git a/mojo/edk/system/core.cc b/mojo/edk/system/core.cc

index ca6105de0f2494c2f650c1eaa4dae0c1b4904cc8..b3602d7c5f4a166aee775a7edf0f5daaef43187c 100644

--- a/mojo/edk/system/core.cc

+++ b/mojo/edk/system/core.cc

@@ -160,7 +160,6 @@ MojoResult Core::CreateSharedBufferWrapper(

bool read_only,

MojoHandle* mojo_wrapper_handle) {

DCHECK(num_bytes);

- CHECK(!read_only);

scoped_refptr<PlatformSharedBuffer> platform_buffer =

PlatformSharedBuffer::CreateFromSharedMemoryHandle(num_bytes, read_only,

shared_memory_handle);

@@ -214,7 +213,7 @@ MojoResult Core::PassSharedMemoryHandle(

if (num_bytes)

*num_bytes = platform_shared_buffer->GetNumBytes();

if (read_only)

- *read_only = false;

+ *read_only = platform_shared_buffer->IsReadOnly();

*shared_memory_handle = platform_shared_buffer->DuplicateSharedMemoryHandle();

shm_dispatcher->Close();

« no previous file with comments | « mojo/edk/system/broker_posix.cc ('k') | mojo/edk/system/data_pipe_consumer_dispatcher.cc » ('j') | no next file with comments »