content/renderer/media/android/webmediaplayer_android.h - Issue 1689043002: Add WebMediaPlayer::exitedFullscreen() and call it from HTMLMediaElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/android/webmediaplayer_android.h

Issue 1689043002: Add WebMediaPlayer::exitedFullscreen() and call it from HTMLMediaElement (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/media/android/webmediaplayer_android.h

diff --git a/content/renderer/media/android/webmediaplayer_android.h b/content/renderer/media/android/webmediaplayer_android.h

index 5be4eca965c456ce574648f46a6467103983d52d..7c0631f267fdbcb60df02e74777253e7ade23c7f 100644

--- a/content/renderer/media/android/webmediaplayer_android.h

+++ b/content/renderer/media/android/webmediaplayer_android.h

@@ -88,7 +88,7 @@ class WebMediaPlayerAndroid

// MediaPlayerAndroid object in the browser process through |proxy|.

// TODO(qinmin): |frame| argument is used to determine whether the current

// player can enter fullscreen. This logic should probably be moved into

- // blink, so that enterFullscreen() will not be called if another video is

+ // blink, so that enteredFullscreen() will not be called if another video is

// already in fullscreen.

WebMediaPlayerAndroid(

blink::WebFrame* frame,

@@ -105,7 +105,7 @@ class WebMediaPlayerAndroid

// blink::WebMediaPlayer implementation.

bool supportsOverlayFullscreenVideo() override;

- void enterFullscreen() override;

+ void enteredFullscreen() override;

// Resource loading.

void load(LoadType load_type,

« no previous file with comments | « no previous file | content/renderer/media/android/webmediaplayer_android.cc » ('j') | no next file with comments »