Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 1689013002: Use Uris for corelibOrder (Closed)

Created:
4 years, 10 months ago by ochafik
Modified:
4 years, 10 months ago
Reviewers:
vsm, Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use Uris for corelibOrder (Seems to make some sdk imports not lazy anymore, without even burning the house) Also, tiny module-related fixes to help with some es6 tools such as rollup: - Avoid self-importing in eager corelibOrder hack - Always export exports in es6 module builder BUG= R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/c21b5d43eeb370e8fbdcc3e762d5e6969375d138

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -59 lines) Patch
M lib/runtime/dart/_isolate_helper.js View 1 chunk +3 lines, -3 lines 0 comments Download
M lib/runtime/dart/html.js View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/src/codegen/js_codegen.dart View 2 chunks +6 lines, -4 lines 0 comments Download
M lib/src/codegen/js_module_item_order.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/src/codegen/module_builder.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/src/compiler.dart View 1 chunk +25 lines, -46 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
ochafik
4 years, 10 months ago (2016-02-11 00:00:13 UTC) #5
Jennifer Messerly
LGTM!
4 years, 10 months ago (2016-02-11 17:23:47 UTC) #6
ochafik
4 years, 10 months ago (2016-02-11 17:28:10 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
c21b5d43eeb370e8fbdcc3e762d5e6969375d138 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698