lib/src/codegen/js_module_item_order.dart - Issue 1689013002: Use Uris for corelibOrder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/codegen/js_module_item_order.dart

Issue 1689013002: Use Uris for corelibOrder (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/codegen/js_module_item_order.dart

diff --git a/lib/src/codegen/js_module_item_order.dart b/lib/src/codegen/js_module_item_order.dart

index d35b1d72f4aa25665b6608c8dbb2a20256e906f2..8cffbacc796febda919c19832c34f619dc97ac8e 100644

--- a/lib/src/codegen/js_module_item_order.dart

+++ b/lib/src/codegen/js_module_item_order.dart

@@ -217,10 +217,10 @@ class ModuleItemLoadOrder {

if (!_isDartUri(_currentLibrary)) return true;

// Compute the order of both SDK libraries. If unknown, assume it's after.

- var order = corelibOrder.indexOf(library.name);

+ var order = corelibOrder.indexOf(library.source.uri);

if (order == -1) order = corelibOrder.length;

- var currentOrder = corelibOrder.indexOf(_currentLibrary.name);

+ var currentOrder = corelibOrder.indexOf(_currentLibrary.source.uri);

if (currentOrder == -1) currentOrder = corelibOrder.length;

// If the dart:* library we are currently compiling is loaded after the

« no previous file with comments | « lib/src/codegen/js_codegen.dart ('k') | lib/src/codegen/module_builder.dart » ('j') | no next file with comments »