Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1688953004: [builtins] Add an initial fast-path to Object.assign. (Closed)

Created:
4 years, 10 months ago by Toon Verwaest
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Add an initial fast-path to Object.assign. In the case of a simple fast-mode receiver without fancy properties, we can just walk over the descriptor array to find all its initial property names. As long as the map stays the same, we can also use that descriptor array to figure out how to handle the properties. This speeds up https://github.com/kpdecker/six-speed/tree/master/tests/object-assign by ~2x. BUG= Committed: https://crrev.com/6b89c6941b13373a7ab1c484bddffcd9d0fea559 Cr-Commit-Position: refs/heads/master@{#33895}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -30 lines) Patch
M src/builtins.cc View 1 2 chunks +73 lines, -1 line 0 comments Download
M src/lookup.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/messages.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 2 chunks +5 lines, -2 lines 0 comments Download
M src/objects.cc View 1 3 chunks +14 lines, -26 lines 1 comment Download
M src/property-details.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/es6/object-assign.js View 1 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Toon Verwaest
cbruni: PTAL bmeurer: FYI
4 years, 10 months ago (2016-02-11 10:57:31 UTC) #2
Benedikt Meurer
LGTM, nice
4 years, 10 months ago (2016-02-11 11:28:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688953004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688953004/20001
4 years, 10 months ago (2016-02-11 12:40:13 UTC) #5
Camillo Bruni
lgtm https://codereview.chromium.org/1688953004/diff/20001/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/1688953004/diff/20001/src/objects.cc#newcode8556 src/objects.cc:8556: bool cache_enum_length = map->OnlyHasSimpleProperties(); yay! readable code :)
4 years, 10 months ago (2016-02-11 13:03:54 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-11 13:17:20 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-11 13:19:01 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6b89c6941b13373a7ab1c484bddffcd9d0fea559
Cr-Commit-Position: refs/heads/master@{#33895}

Powered by Google App Engine
This is Rietveld 408576698