src/property-details.h - Issue 1688953004: [builtins] Add an initial fast-path to Object.assign.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/property-details.h

Issue 1688953004: [builtins] Add an initial fast-path to Object.assign. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/property-details.h

diff --git a/src/property-details.h b/src/property-details.h

index 01592610681aecc9d2a7f6b08c3fedcf6b7aff7e..fdf2c6c4ab5fc0c6cec0d00921583451c5c7848a 100644

--- a/src/property-details.h

+++ b/src/property-details.h

@@ -330,6 +330,7 @@ class PropertyDetails BASE_EMBEDDED {

bool IsReadOnly() const { return (attributes() & READ_ONLY) != 0; }

bool IsConfigurable() const { return (attributes() & DONT_DELETE) == 0; }

bool IsDontEnum() const { return (attributes() & DONT_ENUM) != 0; }

+ bool IsEnumerable() const { return !IsDontEnum(); }

PropertyCellType cell_type() const {

return PropertyCellTypeField::decode(value_);

}