Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Issue 1688903002: gn: Only copy dbghelp.dll for the default toolchain. (Closed)

Created:
4 years, 10 months ago by Nico
Modified:
4 years, 10 months ago
Reviewers:
scottmg
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: Only copy dbghelp.dll for the default toolchain. This has the effect of not copying dbghelp.dll into the nacl toolchain dir. Doing this isn't really harmful, but also not useful. Follow-up to https://codereview.chromium.org/1683793003/ BUG=460506, 461160, 498033 Committed: https://crrev.com/ec0d7d23891d5d61a7ff0a7add476a6b574db4c2 Cr-Commit-Position: refs/heads/master@{#374723}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M base/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Nico
4 years, 10 months ago (2016-02-10 20:08:42 UTC) #2
scottmg
lgtm
4 years, 10 months ago (2016-02-10 20:09:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688903002/1
4 years, 10 months ago (2016-02-10 20:13:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 21:12:32 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:31:03 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec0d7d23891d5d61a7ff0a7add476a6b574db4c2
Cr-Commit-Position: refs/heads/master@{#374723}

Powered by Google App Engine
This is Rietveld 408576698