Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: base/BUILD.gn

Issue 1688903002: gn: Only copy dbghelp.dll for the default toolchain. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/BUILD.gn
diff --git a/base/BUILD.gn b/base/BUILD.gn
index 7a6c73aae04873081db181cc306bc4f692e5210a..ade7e02ba5d72940766c51e06b7092a5c8d9df28 100644
--- a/base/BUILD.gn
+++ b/base/BUILD.gn
@@ -1120,10 +1120,10 @@ component("base") {
# Required for base/stack_trace_win.cc to symbolize correctly.
data += [ "$root_build_dir/dbghelp.dll" ]
- deps += [
- ":copy_dbghelp.dll",
- "//base/trace_event/etw_manifest:chrome_events_win",
- ]
+ deps += [ "//base/trace_event/etw_manifest:chrome_events_win" ]
+ if (current_toolchain == default_toolchain) {
+ deps += [ ":copy_dbghelp.dll" ]
+ }
if (is_component_build) {
# Copy the VS runtime DLLs into the isolate so that they don't have to be
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698