src/client/linux/minidump_writer/linux_dumper.h - Issue 1688743002: Switch the Linux minidump writer to use MDCVInfoELF for CV data.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/client/linux/minidump_writer/linux_dumper.h

Issue 1688743002: Switch the Linux minidump writer to use MDCVInfoELF for CV data. (Closed) Base URL: https://chromium.googlesource.com/breakpad/breakpad.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/client/linux/microdump_writer/microdump_writer.cc ('K') | « src/client/linux/microdump_writer/microdump_writer.cc ('k') | src/client/linux/minidump_writer/linux_dumper.cc » ('j') | src/common/linux/file_id.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/client/linux/minidump_writer/linux_dumper.h

diff --git a/src/client/linux/minidump_writer/linux_dumper.h b/src/client/linux/minidump_writer/linux_dumper.h

index 6a3a100f32376e125490a64376c7318a76c4486f..08b64f926cd506a4630c3ce3363f7289174f3357 100644

--- a/src/client/linux/minidump_writer/linux_dumper.h

+++ b/src/client/linux/minidump_writer/linux_dumper.h

@@ -49,6 +49,7 @@

#include "client/linux/dump_writer_common/mapping_info.h"

#include "client/linux/dump_writer_common/thread_info.h"

+#include "common/linux/file_id.h"

#include "common/memory.h"

#include "google_breakpad/common/minidump_format.h"

@@ -127,7 +128,8 @@ class LinuxDumper {

bool ElfFileIdentifierForMapping(const MappingInfo& mapping,

bool member,

unsigned int mapping_id,

- uint8_t identifier[sizeof(MDGUID)]);

+ uint8_t identifier[kMaxBuildID],

+ size_t* identifier_length);

uintptr_t crash_address() const { return crash_address_; }

void set_crash_address(uintptr_t crash_address) {