Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: src/client/linux/minidump_writer/linux_dumper.cc

Issue 1688743002: Switch the Linux minidump writer to use MDCVInfoELF for CV data. (Closed) Base URL: https://chromium.googlesource.com/breakpad/breakpad.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/client/linux/minidump_writer/linux_dumper.cc
diff --git a/src/client/linux/minidump_writer/linux_dumper.cc b/src/client/linux/minidump_writer/linux_dumper.cc
index 43b74ad9de7e4e536e4622aaa21d24705af5a9e0..8a5df31b797013c2f2c7a177303e82b053c84921 100644
--- a/src/client/linux/minidump_writer/linux_dumper.cc
+++ b/src/client/linux/minidump_writer/linux_dumper.cc
@@ -119,9 +119,11 @@ bool
LinuxDumper::ElfFileIdentifierForMapping(const MappingInfo& mapping,
bool member,
unsigned int mapping_id,
- uint8_t identifier[sizeof(MDGUID)]) {
+ uint8_t identifier[kMaxBuildID],
+ size_t* identifier_length) {
assert(!member || mapping_id < mappings_.size());
- my_memset(identifier, 0, sizeof(MDGUID));
+ assert(identifier_length);
+ my_memset(identifier, 0, kMaxBuildID);
if (IsMappedFileOpenUnsafe(mapping))
return false;
@@ -136,7 +138,9 @@ LinuxDumper::ElfFileIdentifierForMapping(const MappingInfo& mapping,
reinterpret_cast<const void*>(mapping.start_addr),
mapping.size);
}
- return FileID::ElfFileIdentifierFromMappedFile(linux_gate, identifier);
+ return FileID::ElfFileIdentifierFromMappedFile(linux_gate,
+ identifier,
+ identifier_length);
}
char filename[NAME_MAX];
@@ -154,7 +158,9 @@ LinuxDumper::ElfFileIdentifierForMapping(const MappingInfo& mapping,
return false;
bool success =
- FileID::ElfFileIdentifierFromMappedFile(mapped_file.data(), identifier);
+ FileID::ElfFileIdentifierFromMappedFile(mapped_file.data(),
+ identifier,
+ identifier_length);
if (success && member && filename_modified) {
mappings_[mapping_id]->name[filename_len -
sizeof(kDeletedSuffix) + 1] = '\0';

Powered by Google App Engine
This is Rietveld 408576698