Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.idl

Issue 1688573002: ServiceWorkerMessageEvent shouldn't hold ScriptValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.idl
diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.idl b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.idl
index 711f643d8abf0b0bf436b74a237ab53cd30c09a0..f1109251ca7d52d996857e9568c03619e1c2bba0 100644
--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.idl
+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.idl
@@ -5,7 +5,11 @@
// https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#serviceworkermessage-event-interface
[
- Constructor(DOMString type, optional ServiceWorkerMessageEventInit eventInitDict),
+ // TODO(bashi): Stop using CustomConstructor once we solve reference
+ // circulation between Blink and V8. http://crbug.com/501866
+ // Constructor should be:
+ // Constructor(DOMString type, optional ServiceWorkerMessageEventInit eventInitDict),
+ CustomConstructor,
Exposed=(Window, Worker),
] interface ServiceWorkerMessageEvent : Event {
[Custom=Getter] readonly attribute any data;
« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698