third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.cpp - Issue 1688573002: ServiceWorkerMessageEvent shouldn't hold ScriptValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.cpp

Issue 1688573002: ServiceWorkerMessageEvent shouldn't hold ScriptValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.h ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.cpp b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.cpp

index 86630225684ba9cf687c67cc66c788176216447a..757c50d032d62cd608982b969f0d65994f85dd62 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.cpp

@@ -25,8 +25,6 @@ ServiceWorkerMessageEvent::ServiceWorkerMessageEvent(const AtomicString& type, c

}

if (initializer.hasPorts())

m_ports = new MessagePortArray(initializer.ports());

- if (initializer.hasData())

- m_data = initializer.data();

}

ServiceWorkerMessageEvent::ServiceWorkerMessageEvent(PassRefPtr<SerializedScriptValue> data, const String& origin, const String& lastEventId, ServiceWorker* source, MessagePortArray* ports)