third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.h - Issue 1688573002: ServiceWorkerMessageEvent shouldn't hold ScriptValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.h

Issue 1688573002: ServiceWorkerMessageEvent shouldn't hold ScriptValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/modules/v8/custom/V8ServiceWorkerMessageEventCustom.cpp ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.h

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.h b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.h

index da6f44d31e9de016532d4495b2d01367ba138833..a85d09b92288f12f7335c473c7d43b72d1893218 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.h

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.h

@@ -33,8 +33,8 @@ public:

~ServiceWorkerMessageEvent() override;

- ScriptValue data() const { return m_data; }

SerializedScriptValue* serializedData() const { return m_serializedData.get(); }

+ void setSerializedData(PassRefPtr<SerializedScriptValue> serializedData) { m_serializedData = serializedData; }

const String& origin() const { return m_origin; }

const String& lastEventId() const { return m_lastEventId; }

MessagePortArray ports(bool& isNull) const;

@@ -50,7 +50,6 @@ private:

ServiceWorkerMessageEvent(const AtomicString& type, const ServiceWorkerMessageEventInit& initializer);

ServiceWorkerMessageEvent(PassRefPtr<SerializedScriptValue> data, const String& origin, const String& lastEventId, ServiceWorker* source, MessagePortArray* ports);

- ScriptValue m_data;

RefPtr<SerializedScriptValue> m_serializedData;

String m_origin;

String m_lastEventId;