Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.h

Issue 1688573002: ServiceWorkerMessageEvent shouldn't hold ScriptValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.h
diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.h b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.h
index da6f44d31e9de016532d4495b2d01367ba138833..a85d09b92288f12f7335c473c7d43b72d1893218 100644
--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.h
+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.h
@@ -33,8 +33,8 @@ public:
~ServiceWorkerMessageEvent() override;
- ScriptValue data() const { return m_data; }
SerializedScriptValue* serializedData() const { return m_serializedData.get(); }
+ void setSerializedData(PassRefPtr<SerializedScriptValue> serializedData) { m_serializedData = serializedData; }
const String& origin() const { return m_origin; }
const String& lastEventId() const { return m_lastEventId; }
MessagePortArray ports(bool& isNull) const;
@@ -50,7 +50,6 @@ private:
ServiceWorkerMessageEvent(const AtomicString& type, const ServiceWorkerMessageEventInit& initializer);
ServiceWorkerMessageEvent(PassRefPtr<SerializedScriptValue> data, const String& origin, const String& lastEventId, ServiceWorker* source, MessagePortArray* ports);
- ScriptValue m_data;
RefPtr<SerializedScriptValue> m_serializedData;
String m_origin;
String m_lastEventId;

Powered by Google App Engine
This is Rietveld 408576698