Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Unified Diff: test/cctest/interpreter/bytecode-expectations.h

Issue 1688383003: [Interpreter] Change the output format of generate-bytecode-expectations. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Do not create a static lib target. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/interpreter/bytecode-expectations.h
diff --git a/test/cctest/interpreter/bytecode-expectations.h b/test/cctest/interpreter/bytecode-expectations.h
new file mode 100644
index 0000000000000000000000000000000000000000..6f49c5798dcbb0ddeb55eeccf0cdc9e7cef1167d
--- /dev/null
+++ b/test/cctest/interpreter/bytecode-expectations.h
@@ -0,0 +1,39 @@
+// Copyright 2016 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef INTERPRETER_BYTECODE_EXPECTATIONS_H_
+#define INTERPRETER_BYTECODE_EXPECTATIONS_H_
+
+#include <iostream>
+#include <vector>
+
+namespace v8 {
+namespace internal {
+namespace interpreter {
+
+enum ConstantPoolType {
+ kConstantPoolTypeUnknown,
+ kConstantPoolTypeString,
+ kConstantPoolTypeInteger,
+ kConstantPoolTypeDouble,
+ kConstantPoolTypeMixed,
+};
+
+struct TestInput {
+ std::string snippet;
rmcilroy 2016/02/12 12:33:10 Fields go at the end. Also append "_" to the end o
Stefano Sanfilippo 2016/02/12 14:23:59 This struct was removed in the refactoring.
+ ConstantPoolType const_pool_type = kConstantPoolTypeMixed;
+
+ TestInput(const std::string& s, ConstantPoolType p)
+ : snippet(s), const_pool_type(p) {}
+};
+
+void GenerateExpectationsFile(std::ostream& stream,
rmcilroy 2016/02/12 12:33:10 As discussed, let's refactor this into a class and
Stefano Sanfilippo 2016/02/12 14:23:59 Done.
+ const std::vector<TestInput>& test_list,
+ const char* exec_path);
+
+} // namespace interpreter
+} // namespace internal
+} // namespace v8
+
+#endif

Powered by Google App Engine
This is Rietveld 408576698