[Interpreter] Change the output format of generate-bytecode-expectations.

test/cctest/interpreter/bytecode-expectations.h

+// Copyright 2016 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef INTERPRETER_BYTECODE_EXPECTATIONS_H_
+#define INTERPRETER_BYTECODE_EXPECTATIONS_H_
+
+#include <iostream>
+#include <vector>
+
+namespace v8 {
+namespace internal {
+namespace interpreter {
+
+enum ConstantPoolType {
+  kConstantPoolTypeUnknown,
+  kConstantPoolTypeString,
+  kConstantPoolTypeInteger,
+  kConstantPoolTypeDouble,
+  kConstantPoolTypeMixed,
+};
+
+struct TestInput {
+  std::string snippet;

[rmcilroy, 2016/02/12 12:33:10]

Fields go at the end. Also append "_" to the end of field names. I think this
should also be a class with the fields being private and having public getters.

[Stefano Sanfilippo, 2016/02/12 14:23:59]

This struct was removed in the refactoring.

+  ConstantPoolType const_pool_type = kConstantPoolTypeMixed;
+
+  TestInput(const std::string& s, ConstantPoolType p)
+      : snippet(s), const_pool_type(p) {}
+};
+
+void GenerateExpectationsFile(std::ostream& stream,

[rmcilroy, 2016/02/12 12:33:10]

As discussed, let's refactor this into a class and move the V8 initialization
stuff out intp the generate-bytecode-expections.cc file.

[Stefano Sanfilippo, 2016/02/12 14:23:59]

Done.

+                              const std::vector<TestInput>& test_list,
+                              const char* exec_path);
+
+}  // namespace interpreter
+}  // namespace internal
+}  // namespace v8
+
+#endif