[Interpreter] Implements calls through CallICStub in the interpreter.

src/interpreter/bytecode-generator.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/interpreter/bytecode-generator.h"
 
 #include "src/ast/scopes.h"
 #include "src/compiler.h"
 #include "src/interpreter/bytecode-register-allocator.h"
 #include "src/interpreter/control-flow-builders.h"
@@ skipping 2267 matching lines @@
             Smi::FromInt(execution_context()->scope()->start_position()))
         .StoreAccumulatorInRegister(position);
 
     // Call ResolvePossiblyDirectEval and modify the callee.
     builder()
         ->CallRuntime(Runtime::kResolvePossiblyDirectEval, callee_for_eval, 5)
         .StoreAccumulatorInRegister(callee);
   }
 
   builder()->SetExpressionPosition(expr);
-  builder()->Call(callee, receiver, 1 + args->length(),
-                  feedback_index(expr->CallFeedbackICSlot()));
+  if (call_type == Call::POSSIBLY_EVAL_CALL ||
+      call_type == Call::LOOKUP_SLOT_CALL) {

[rmcilroy, 2016/02/12 14:21:03]

Would this be the same if you did:
if (expr->CallFeedbackICSlot().IsInvalid()) {
...


That would seem safer to me.

[mythria, 2016/02/17 11:02:48]

Done. Yes, indeed. I missed it but Lookup_slot_calls go through callIC too. I
verified it in full-codegen. 

+    builder()->Call(callee, receiver, 1 + args->length());
+  } else {
+    builder()->CallIC(callee, receiver, 1 + args->length(),
+                      feedback_index(expr->CallFeedbackICSlot()));
+  }
   execution_result()->SetResultInAccumulator();
 }
 
 
 void BytecodeGenerator::VisitCallNew(CallNew* expr) {
   Register constructor = register_allocator()->NewRegister();
   VisitForAccumulatorValue(expr->expression());
   builder()->StoreAccumulatorInRegister(constructor);
 
   ZoneList<Expression*>* args = expr->arguments();
@@ skipping 591 matching lines @@
 }
 
 
 int BytecodeGenerator::feedback_index(FeedbackVectorSlot slot) const {
   return info()->feedback_vector()->GetIndex(slot);
 }
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8