Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/LiveLocation.js

Issue 1688283002: [DevTools] Blackboxing in LiveLocations is supported in Linkifier (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-source-map-support-v3
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/bindings/LiveLocation.js
diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/LiveLocation.js b/third_party/WebKit/Source/devtools/front_end/bindings/LiveLocation.js
index 2cc65c3a03552bd8d4b060e831dea407f2b670ab..ea1ad3879a86528f64aac8f564297e658ed2e822 100644
--- a/third_party/WebKit/Source/devtools/front_end/bindings/LiveLocation.js
+++ b/third_party/WebKit/Source/devtools/front_end/bindings/LiveLocation.js
@@ -4,27 +4,27 @@
/**
* @constructor
- * @param {function(!WebInspector.UILocation):(boolean|undefined)} updateDelegate
+ * @param {function(!WebInspector.LiveLocation)} updateDelegate
*/
WebInspector.LiveLocation = function(updateDelegate)
{
this._updateDelegate = updateDelegate;
+ /** @type {?WebInspector.UILocation} */
+ this.uiLocation = null;
}
WebInspector.LiveLocation.prototype = {
update: function()
{
- var uiLocation = this.uiLocation();
- if (!uiLocation)
- return;
- if (this._updateDelegate(uiLocation))
- this.dispose();
+ this.uiLocation = this._updateUILocation();
dgozman 2016/02/18 02:17:53 Let's not store it, better check in client.
kozy 2016/02/18 02:36:25 Done.
+ if (this.uiLocation)
+ this._updateDelegate(this);
},
/**
* @return {?WebInspector.UILocation}
*/
- uiLocation: function()
+ _updateUILocation: function()
{
throw "Not implemented";
},
@@ -32,5 +32,13 @@ WebInspector.LiveLocation.prototype = {
dispose: function()
{
// Overridden by subclasses.
+ },
+
+ /**
+ * @return {boolean}
+ */
+ isBlackboxed: function()
+ {
+ throw "Not implemented";
}
}

Powered by Google App Engine
This is Rietveld 408576698