third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js - Issue 1688283002: [DevTools] Blackboxing in LiveLocations is supported in Linkifier

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js

Issue 1688283002: [DevTools] Blackboxing in LiveLocations is supported in Linkifier (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-source-map-support-v3

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/elements/styles/update-locations-on-filesystem-scss-load.html ('k') | third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js » ('j') | third_party/WebKit/Source/devtools/front_end/bindings/LiveLocation.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js

diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js b/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js

index 8751939299018e35c1135a7eff5f9af728764685..be2e646b1b1acb494cc7ec1a53e923a5fceb2fa8 100644

--- a/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js

+++ b/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js

@@ -24,7 +24,6 @@ WebInspector.BlackboxManager = function(debuggerWorkspaceBinding, networkMapping

}

WebInspector.BlackboxManager.prototype = {

/**

* @param {function(!WebInspector.Event)} listener

* @param {!Object=} thisObject

@@ -310,9 +309,10 @@ WebInspector.BlackboxManager.prototype = {

function updateState(success)

{

- if (success)

+ if (success) {

this._scriptIdToPositions.set(script.scriptId, positions);

- else if (!this._scriptIdToPositions.has(script.scriptId))

+ this._debuggerWorkspaceBinding.updateLocations(script);

+ } else if (!this._scriptIdToPositions.has(script.scriptId))

dgozman 2016/02/18 02:17:53 nit: {} for both branches please

kozy 2016/02/18 02:36:25 Done.

this._scriptIdToPositions.set(script.scriptId, []);

}