Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1688233002: new version of SkHalfToFloat_01 (Closed)

Created:
4 years, 10 months ago by mtklein_C
Modified:
4 years, 10 months ago
Reviewers:
herb_g, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

new version of SkHalfToFloat_01 This is a little faster than the previous version, and much better explained. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1688233002 Committed: https://skia.googlesource.com/skia/+/ddb64c81fbe05ef7188135564bbd695edea9fdf0

Patch Set 1 #

Patch Set 2 : restore #

Patch Set 3 : swap cast order, neon on the brain #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -16 lines) Patch
M src/core/SkHalf.h View 1 2 2 chunks +23 lines, -16 lines 0 comments Download
M tests/Float16Test.cpp View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688233002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688233002/20001
4 years, 10 months ago (2016-02-11 19:46:12 UTC) #3
mtklein_C
4 years, 10 months ago (2016-02-11 19:46:13 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/6047) Build-Ubuntu-GCC-x86_64-Release-Trybot on ...
4 years, 10 months ago (2016-02-11 19:47:51 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688233002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688233002/40001
4 years, 10 months ago (2016-02-11 19:52:04 UTC) #9
herb_g
lgtm
4 years, 10 months ago (2016-02-11 20:06:17 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-11 20:17:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688233002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688233002/40001
4 years, 10 months ago (2016-02-11 20:47:27 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-02-11 20:48:25 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/ddb64c81fbe05ef7188135564bbd695edea9fdf0

Powered by Google App Engine
This is Rietveld 408576698