Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: Source/WebKit/chromium/WebKitUnitTests.gyp

Issue 16881011: Remove WEBKIT_DLL and replace it with COMPONENT_BUILD (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: updates Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/WebKit/chromium/WebKit.gyp ('k') | Source/core/core.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebKit/chromium/WebKitUnitTests.gyp
diff --git a/Source/WebKit/chromium/WebKitUnitTests.gyp b/Source/WebKit/chromium/WebKitUnitTests.gyp
index 3e08135598b869e3d6849a1c2cc3baab1c5defd3..41e597ffe6e79e9f36ee1e988d7e3601257865f8 100644
--- a/Source/WebKit/chromium/WebKitUnitTests.gyp
+++ b/Source/WebKit/chromium/WebKitUnitTests.gyp
@@ -63,11 +63,7 @@
'src',
],
'conditions': [
- ['component=="shared_library"', {
- 'defines': [
- 'WEBKIT_DLL_UNITTEST',
darin (slow to review) 2013/06/19 21:05:47 I think this change nuked webkit_unit_tests in the
jamesr 2013/06/19 21:06:52 Yikes, that's right! Why did you remove this, Joc
jochen (gone - plz use gerrit) 2013/06/20 10:49:12 OMG, that was a careless mistake :-/ Sorry about
- ],
- }, {
+ ['component!="shared_library"', {
'dependencies': [
'../../core/core.gyp:webcore',
],
« no previous file with comments | « Source/WebKit/chromium/WebKit.gyp ('k') | Source/core/core.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698